Ryan Schultz
8afacf268a
- Hover provider showing entity information and type - Go-to-definition (F12) for entity references - Basic IFC file validation (ISO-10303-21 header check) - Entity parsing with regex-based detection - Proper CommonJS module system (avoiding ES module issues) This replaces the broken baseline from ifc-developer-tools which had: - Non-functional ES module configuration - Circular dependency issues - Parser crashes - Non-working PositionVisitor Built on Microsoft's LSP example template for a clean, maintainable foundation. Next: Add hierarchical entity dependency tree in hover tooltip."
77 lines
1.7 KiB
JavaScript
77 lines
1.7 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag comparison where left part is the same as the right
|
|
* part.
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../types').Rule.RuleModule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description:
|
|
"Disallow comparisons where both sides are exactly the same",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-self-compare",
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
comparingToSelf: "Comparing to itself is potentially pointless.",
|
|
},
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Determines whether two nodes are composed of the same tokens.
|
|
* @param {ASTNode} nodeA The first node
|
|
* @param {ASTNode} nodeB The second node
|
|
* @returns {boolean} true if the nodes have identical token representations
|
|
*/
|
|
function hasSameTokens(nodeA, nodeB) {
|
|
const tokensA = sourceCode.getTokens(nodeA);
|
|
const tokensB = sourceCode.getTokens(nodeB);
|
|
|
|
return (
|
|
tokensA.length === tokensB.length &&
|
|
tokensA.every(
|
|
(token, index) =>
|
|
token.type === tokensB[index].type &&
|
|
token.value === tokensB[index].value,
|
|
)
|
|
);
|
|
}
|
|
|
|
return {
|
|
BinaryExpression(node) {
|
|
const operators = new Set([
|
|
"===",
|
|
"==",
|
|
"!==",
|
|
"!=",
|
|
">",
|
|
"<",
|
|
">=",
|
|
"<=",
|
|
]);
|
|
|
|
if (
|
|
operators.has(node.operator) &&
|
|
hasSameTokens(node.left, node.right)
|
|
) {
|
|
context.report({ node, messageId: "comparingToSelf" });
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|